search

haskelly-dev / Haskelly

Haskelly is a VS Code extension that provides complete support for casual and expert Haskell development.
https://marketplace.visualstudio.com/items?itemName=UCL.haskelly
GNU General Public License v3.0
152 stars 17 forks source link

Support jump to definition functionality #61

Closed ryu1kn closed 6 years ago

ryu1kn commented 6 years ago

Not tested on Windows 🙃

ryu1kn commented 6 years ago

This PR is for https://github.com/haskelly-dev/Haskelly/issues/33

ryu1kn commented 6 years ago

Any chances to review the PR @martrik ?

martrik commented 6 years ago

Hey @ryu1kn! Thanks for the PR, I'll have a look at it this weekend, but it seems that I'll be able to merge it right away. I've got one question though, do you have any idea on how to implement this also for external libraries?

ryu1kn commented 6 years ago

It would really depend on intero and I haven’t looked at it much. Sometimes jump to definition takes you to the source of external libraries under .stack-work directory. There might be some way to tell intero to look for definitions under certain directories like ~/.cabal or ~/.stack.

martrik commented 6 years ago

I see... I'll merge this then and we can later build on this feature.

martrik commented 6 years ago

I'll deploy the new version to the store in a couple of days :)