search

haskelly-dev / Haskelly

Haskelly is a VS Code extension that provides complete support for casual and expert Haskell development.
https://marketplace.visualstudio.com/items?itemName=UCL.haskelly
GNU General Public License v3.0
152 stars 17 forks source link

[Discussion] [Live Share] Restricting language services to local files #74

Closed lostintangent closed 6 years ago

lostintangent commented 6 years ago

In preparation for Visual Studio Live Share adding support for "guests" to receive remote language services for Haskell, this PR simply updates the current DocumentSelector to be limited to file and untitled (unsaved) files. This way, when someone has this extension installed, and joins a Live Share session (where files use the vsls: scheme), their language services will be entirely derived from the remote/host side, which provides a more accurate and project-wide experience (guests in Live Share don't have local file access to the project they're collaborating with).

Note: As an example, the TypeScript/JavaScript language services that come in-box with VS Code already have this scheme restriction, and so this PR replicates that behavior.

martrik commented 6 years ago

Thanks a lot for the contribution @lostintangent!

martrik commented 6 years ago

This patch has been released in version 0.5.2 of Haskelly.