search

hatchways / team-penguin

World Chat Messenger allows users from completely different language backgrounds to converse with each other in their own language taking globalization to the next level.
2 stars 0 forks source link

Fe/sign up login #43

Closed rjtbansal closed 4 years ago

rjtbansal commented 4 years ago

Issue #10

sina-jamshidi commented 4 years ago

Issue #10

  • Both login and sign up pages mostly complete with styling
  • Switching between Login and Sign Up pages functional
  • Used a different icon for chat on left side image because I couldnt find the one on the mockup
  • Was unable to change color of 'Forgot' input adornment text in password field of login page (guidance needed on that)
  • Validation of form fields is still pending

Overall looks great! Please continue work on the integration and for validation, keep it to something simple like: all fields are filled out (ie. they are not === ""), email is an email, and password length is 6 >.

rjtbansal commented 4 years ago

Sign Up FE is complete along with client side validations. Moving to Login FE client side form validations.

rjtbansal commented 4 years ago

Login and Sign up complete. Awaiting review prior to merging. Will switch to integration ticket.

cch5ng commented 4 years ago

(update) comments were added at the end of each gist to highlight important line numbers

hi, looks very good. I don't have too many style comments.

I was concerned about the updating the global state parts. perhaps you are putting that off for the integration. in case, I wrote up a couple sample gists (related to auth-context.js and handling the login submit) but if you have a plan for it already, you can disregard.

https://gist.github.com/cch5ng/41aefd7607d841f65494c4bd7788c512

https://gist.github.com/cch5ng/e12b14bf1d361a33cd7f3b013db37599

rjtbansal commented 4 years ago

@cch5ng The states for now are only dealing with sign ups and login validation. SIgn up has also been integrated just now with BE. For login integration with backend things will change and I will go through gists you shared as well. Can you elaborate as to which part so far you are concerned about?

cch5ng commented 4 years ago

@cch5ng The states for now are only dealing with sign ups and login validation. SIgn up has also been integrated just now with BE. For login integration with backend things will change and I will go through gists you shared as well. Can you elaborate as to which part so far you are concerned about?

not concern. I just meant that those are main dependencies for what I'm working on. no worries.