Closed rjtbansal closed 4 years ago
Bonnie, I made the change to the BE. the reason was that the last decision was to change the invitation model to reference the user email instead of user id. so I updated the route to query that model.
On Fri, May 29, 2020 at 8:48 AM Bonnie Li notifications@github.com wrote:
@bonnieli commented on this pull request.
In client/src/components/Sidebar/Contacts/Contacts.js https://github.com/hatchways/team-penguin/pull/53#discussion_r432575353:
@@ -12,12 +12,18 @@ const Contacts = props => { const toggleDisplay = (event, setting) => { setDisplay(setting); }
- const [friends, setFriends] = React.useState([]);
- const email = localStorage.getItem('email');
- const loadFriends = async() => {
- const res = await axios.get(
http://localhost:3001/invitations/user/${email}/contacts
http://localhost:3001/invitations/user/$%7Bemail%7D/contacts);has this route been created? if so can you lead me to the backend file?
we probably don't want to pass in email to the backend, rather than the id
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/hatchways/team-penguin/pull/53#pullrequestreview-421074771, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABEI72DCCT52IHVVPF2MTC3RT7KM5ANCNFSM4NNYUU4Q .
got it - lgtm