dumbbell commented 3 years ago

One use case if when the caller wants to clear the STATUS of a service using systemd:notify({status, ""}).

Fixes #26.

codecov[bot] commented 3 years ago

Codecov Report

Merging #27 (164ac26) into master (0ce748e) will decrease coverage by 0.05%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   91.46%   91.41%   -0.06%     
==========================================
  Files           8        8              
  Lines         328      326       -2     
==========================================
- Hits          300      298       -2     
  Misses         28       28

Impacted Files	Coverage Δ
src/systemd_protocol.erl	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0ce748e...164ac26. Read the comment docs.

hauleth commented 3 years ago

Why is this marked as WIP?

dumbbell commented 3 years ago

There is a flaky test, I wonder if this is caused by the patch. I will continue to debug this tomorrow when I'm back at work.

hauleth commented 3 years ago

@dumbbell I am aware of the flaky test. It isn't your doing and I am trying to find a way to circumvent this. If that is the only thing, then I can merge it already.

dumbbell commented 3 years ago

Cool, thank you :)

hauleth commented 3 years ago

💚 💙 💜 💛 ❤️

hauleth / erlang-systemd

systemd_protocol: Keep empty values in encode_field/2 #27

Codecov Report