hauleth / erlang-systemd

systemd utilities for Erlang applications
Apache License 2.0
174 stars 19 forks source link

Add Erlang 24 support #29

Closed dumbbell closed 3 years ago

dumbbell commented 3 years ago

There are three parts in this pull request:

  1. An update to the GitHub workflow to test against Erlang 23 and 24, thanks to @pjk25.
  2. Various changes to the testsuites to make them work on Erlang 24.
  3. A change to the message encoding to fix the library on Erlang 24.

Without the latest point, RabbitMQ master branch fails to notify systemd with the {error, {invalid, {iov, {element_not_binary, 1}}}} and the start command hangs.

codecov[bot] commented 3 years ago

Codecov Report

Merging #29 (45cc341) into master (c5b3a5b) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files           8        8           
  Lines         326      326           
=======================================
  Hits          298      298           
  Misses         28       28           
Impacted Files Coverage Ξ”
src/systemd_protocol.erl 100.00% <100.00%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update c5b3a5b...45cc341. Read the comment docs.

michaelklishin commented 3 years ago

@hauleth sorry to mention you personally but this issue is kind of a blocker for team RabbitMQ's pipelines on Erlang 24. Would it be possible to take a look at this PR soon? We are happy to contribute what we need (or fix issues we run into) and would very much like to not use a fork :)

hauleth commented 3 years ago

Looking into it right now.

hauleth commented 3 years ago

I will publish fixed version later today.

michaelklishin commented 3 years ago

Thank you!

hauleth commented 3 years ago

@michaelklishin published as 0.6.1

hauleth commented 3 years ago

πŸ’š πŸ’™ πŸ’œ πŸ’› ❀️