search

hbdat / eccv20_Multi_Task_Procedure_Learning

Self-Supervised Multi-Task Procedure Learning from Instructional Videos @ ECCV20
MIT License
6 stars 2 forks source link

raw_data_dir not present in global_setting #3

Closed Sid2697 closed 2 years ago

Sid2697 commented 3 years ago

Hey!

The script FeatureVGGDataset.py imports and uses raw_data_dir from global_setting. However, raw_data_dir variable is not declared in global_setting.

For my purpose, I was able to run the code by setting raw_data_dir to None in global_setting. However, I guess, we should add a condition in FeatureVGGDataset.py at line 41 https://github.com/hbdat/eccv20_Multi_Task_Procedure_Learning/blob/7783e7b9b47498933d359adfd761579f09934c3c/core/FeatureVGGDataset.py#L41 for avoiding the error when we do not want to visualise the dataset.

Regards, Siddhant Bansal

hbdat commented 3 years ago

Hi @Sid2697 ,

Thanks a lot for raising the issue. I will add a condition like you suggest to avoid this error.

Sorry for my late response, somehow the notifications got lost in my mailbox.

Best, Dat

Sid2697 commented 3 years ago

Thanks a lot for raising the issue. I will add a condition like you suggest to avoid this error.

That will be great, thanks!

Sorry for my late response, somehow the notifications got lost in my mailbox.

That is completely fine! Can you please have a look at the issue #5?

hbdat commented 3 years ago

I have uploaded the internal .mat file which should fix #5 (please prefer to my answer for more details).

Best, Dat

Sid2697 commented 3 years ago

Thanks a lot for sharing the annotations!

Do you want me to create a PR for this issue?

hbdat commented 3 years ago

Sure. I would appreciate that. Thanks @Sid2697 .