search

hbz / qa-catalogue

QA catalogue – a metadata quality assessment tool for library catalogue records (MARC, PICA)
GNU General Public License v3.0
0 stars 0 forks source link

Some catalogue specific elements do not work properly #14

Open TobiasNx opened 1 week ago

TobiasNx commented 1 week ago

Some of the changes in GKT and other hbz specific elements with letters do not validate properly even if they are configured:

grafik

https://github.com/hbz/qa-catalogue/blob/275f9cf5717e61d0be3de0efacbcc05ea970a7a0/src/main/java/de/gwdg/metadataqa/marc/definition/tags/hbztags/TagGKT.java#L55-L64

TobiasNx commented 3 days ago

The same happens with core specific enhancements: https://github.com/hbz/qa-catalogue/issues/13

pkiraly commented 3 days ago

Did you specified the local version with --marcVersion? Could you send me the parameters you applied for the validation?

TobiasNx commented 2 days ago

https://github.com/hbz/qa-catalogue/blob/275f9cf5717e61d0be3de0efacbcc05ea970a7a0/catalogues/hbz.sh#L14

pkiraly commented 2 days ago

Thanks! It seems OK. The next step would be to write a unit test. If you could add a file with about 1-2 MARCXML records into src/test/resources/marc of your fork? I would write the unit tests and it helps detecting the errors.