search

hearsaycorp / django-livefield

Convenient soft-deletion for Django models.
MIT License
35 stars 19 forks source link

Add Python 3 and Django 1.8 support #32

Closed grantmcconnaughey closed 8 years ago

grantmcconnaughey commented 8 years ago

Huzzah! Finally got the build to pass. I added Django 1.8 support back. The only change was to the hard_delete() method. It now returns the number of results on Django 1.9 and simply returns None on Django 1.8.

I also added Python 3 support. Turns out this package already supported Python 3 just fine! I only had to change one test that referenced the built-in long (which is not in Python 3). I've updated the PyPI classifiers to indicate the versions of Python/Django this app supports. I also added them to the README so users can quickly see what is supported.

Lastly, I've updated the Travis build to test all of the supported versions of Python and Django, so if there are any build issues you'll know immediately what version is broken. This also required me to change the MySQL dependency to one that supports Python 3.

grantmcconnaughey commented 8 years ago

@adepue Any issues with this PR that I should address?

grantmcconnaughey commented 8 years ago

Reset Travis to use DJANGO_VERSION_CEILING. No idea why I changed it. It now tests against 1.8 and 1.9.

adepue commented 8 years ago

Thanks! Merged, version bumped and pushed to pypi