hearsaycorp / django-livefield

Convenient soft-deletion for Django models.
MIT License
35 stars 19 forks source link

Django-1.10 #37

Closed droanrishi closed 7 years ago

droanrishi commented 7 years ago

Due to the fact that Django 1.10 removes get_prep_lookup on models.Field, we don't explicitly block live=False lookups through filter/exclude https://github.com/hearsaycorp/django-livefield/blob/master/src/livefield/fields.py#L35

We need to update that as noted in release notes: https://docs.djangoproject.com/en/1.10/releases/1.10/#field-get-prep-lookup-and-field-get-db-prep-lookup-methods-are-removed

droanrishi commented 7 years ago

@adepue @jtillman for review

jtillman commented 7 years ago

LGTM

droanrishi commented 7 years ago

:shipit: