South compatibility, GeoDjango versions, LiveModel, LiveGeoModel

hearsaycorp / django-livefield

Convenient soft-deletion for Django models.

MIT License

35 stars 19 forks source link

South compatibility, GeoDjango versions, LiveModel, LiveGeoModel #5

Closed dyve closed 10 years ago

dyve commented 10 years ago

South compatibility, GeoDjango versions, LiveModel, LiveGeoModel

Tests pass. I added an extra test run of aal the field tests to test a LiveModel against a hand coded Model with a LiveField.

I changed the file names to match the Django equivalents. Also, consider naming the app 'livefield' instead of 'django-livefield'. Keep the repo and the PyPI name to django-livefield of course.

akshayjshah commented 10 years ago

Generally, this looks great. @dyve, would you mind pulling the GeoDjango stuff into a separate PR? I'd really like to explore how we can add tests for that stuff. The rest of the changes are good to go as-is.

akshayjshah commented 10 years ago

The naming suggestion is good - I'll make that change in a separate PR. We use this package all over the place internally, so I'll need to coordinate the changes.

dyve commented 10 years ago

OK, I'll wait for the name changes first and see if I can put in separate PR's then.

dyve commented 10 years ago

I am working my own version of this into a project with GeoDjango now. I'll contribute my changes. Best way to go forward:

Make the name changes to files and to the app
I'll PR you the changes for standard Django
I'll PR the changes for GeoDjango separately
We'll have to find a way to work GeoDjango tests into the fold

Good news is, the GeoDjango stuff is working in my project :-)