search

hearsaycorp / django-livefield

Convenient soft-deletion for Django models.
MIT License
35 stars 19 forks source link

Update package meta to support Django 2.2 and Python 3.7 #51

Closed shurph closed 5 years ago

shurph commented 5 years ago

Regarding the issue #50 (release with Django 2.2 support) I've added 2.2 to requirements and to the test matrix.

I've also added Python 3.7 to these files because it seems like package works pretty good with python 3.7.

Let me know if it's neccessary to split these two changes to separate PRs.

shurph commented 5 years ago

It seems like current travis environmetn which is used for tests don't support fresh postgres, sqlite and python 3.7 which are required by failed tests. So for tests pass a fresh ubuntu is needed (18.04 or 16.04 at least, I think). Current version, 14.04, can't hold these tests.

shurph commented 5 years ago

Hi @asherf , coul you please take a look at this PR when you will have a chance?

asherf commented 5 years ago

I think this is fine for now to not test SQLite/Postgres on python 3.7 So feel free to remove that. Tests need to pass for this PR to be merged. @rbm @rogerhu

shurph commented 5 years ago

I disabled enviroments which can't work with ubuntu 14.04 as hotfix (hot hack :-) ) Now tests pass.

But I believe if it's possible to switch travis to 18.04 it will be a better solution.

asherf commented 5 years ago

We should switch to that then.. I think you put dist:xenial in the Travis file

shurph commented 5 years ago

Env is updated to Xenial. All tests pass.

shurph commented 5 years ago

Hi @asherf, @rbm @rogerhu could you please provide any updates regarding this pull request?

asherf commented 5 years ago

I am no longer with hearsay (who owns this repo). So I can’t merge this and push the new release to pypi

@rbm can u help here ?

Sent from my iPhone X

On Jun 6, 2019, at 04:02, Mikalai Saskavets notifications@github.com wrote:

Hi @asherf, @rbm @rogerhu could you please provide any updates regarding this pull request?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

rbm commented 5 years ago

@shurph Thanks for the PR! I'm reviewing now.

rbm commented 5 years ago

lgtm

shurph commented 5 years ago

@rbm, thank you!

Could you please release a new version to the PyPi? I need it to use in related project (django-silver, https://github.com/silverapp/silver )