search

hearsaycorp / django-livefield

Convenient soft-deletion for Django models.
MIT License
35 stars 19 forks source link

Add LiveModel to support soft-deletion #7

Closed jlynn closed 10 years ago

jlynn commented 10 years ago

LiveModel can be used as a base class or a Mixin.

akshayjshah commented 10 years ago

Tests?

jlynn commented 10 years ago

You mean these? https://github.com/hearsaycorp/django-livefield/pull/7/files#diff-4

akshayjshah commented 10 years ago

Whaat? Yup, those :) Didn't even see them.

akshayjshah commented 10 years ago

lgtm

jlynn commented 10 years ago

My big question is the following: I can make it a Model that assumes live is a pre-existing field, or I can have the Model define the live field itself. Thoughts?

jlynn commented 10 years ago

Updated to include live on LiveModel

akshayjshah commented 10 years ago

lgtm

hearsaydev commented 10 years ago

Attempting a merge on behalf of ashah. Stand clear!