hearsaycorp / django-livefield

Convenient soft-deletion for Django models.
MIT License
35 stars 19 forks source link

GeoDjango compatibility #9

Closed dyve closed 10 years ago

dyve commented 10 years ago

I did this:

akshayjshah commented 10 years ago

Awesome. Thanks for the PR, Dylan!

Is there a convenient way to test the South and GIS integrations?

dyve commented 10 years ago

South is quite simple.

For GIS you need a GIS DB, either PostGIS (I use this) or Spatialite (I don't use this). I have little experience with automated PostGIS testing (unit tests for my other projects don't require this). Best to ask around I think, or maybe try StackOverflow.

On 9 juli 2014 at 16:38:01, Akshay Shah (notifications@github.com) wrote:

Awesome. Thanks for the PR, Dylan!

Is there a convenient way to test the South and GIS integrations?

— Reply to this email directly or view it on GitHub.

akshayjshah commented 10 years ago

Hrm, you're right - from a quick look around, I don't see a great way to do an end-to-end test of GeoDjango stuff on Travis. Let's table that for now - it should be possible to get some unit tests running with the mock library, but we can come back to that.

If adding a few tests is simple for South, can you add them to this PR?

dyve commented 10 years ago

If you are OK with renaming, it's better to rename first and then add South compatibility, because South wants to know the naming scheme.

I can modify this PR with the new naming scheme (will make for a rather big change), or first get GeoDjango stuff in and rename & add South later.

akshayjshah commented 10 years ago

Let's get the GeoDjango stuff in, then rename, then add South. No sense holding up the GIS integration.

dyve commented 10 years ago

OK, I'll modify this PR, commenting out the South integration.

akshayjshah commented 10 years ago

Works for me.

dyve commented 10 years ago

Also removed the from __future__

akshayjshah commented 10 years ago

Thanks, @dyve! I'm working on the internal renaming now, so we should be able to move ahead with the South integration soon.

dyve commented 10 years ago

Great. I also have UndeleteView (class based view for undelete) ready when the file renaming is done.