helgeerbe / OpenDTU-OnBattery

Software for ESP32 to talk to Hoymiles Inverters and Victrons MPPT battery chargers (Ve.Direct)
GNU General Public License v2.0
297 stars 62 forks source link

Power Meter digest mode not working anymore on [2024.08.18] and [Shelly 20240822-121054] (auth mode "none" works still) #1206

Closed gitisgreat2023 closed 1 month ago

gitisgreat2023 commented 1 month ago

What happened?

Just flashed a board on 2024.08.18. The power meter gives then errors while trying to read out the Shelly in digest mode. Auth "none" still works though.

The errors are various, most common is: 1: HTTP Error: connection lost

I tried many times in "Test configuration" to see other errors. I saw once a power value (in digest mode!) out of 40 times trying. I'm not sure however anymore, couldn't get it a second time.

To Reproduce Bug

Shelly 20240822-121054/1.4.3-g143ff62, 240725095835-ebee9893-HEAD Set Authentication to Enable password protected device.

Then set in OpenDTU-On-Battery Auth mode to digest. It worked perfectly in 2024.06.03.

Expected Behavior

Digest mode works like in in 2024.06.03.

Install Method

Pre-Compiled binary from GitHub

What git-hash/version of OpenDTU?

2024.08.18

Relevant log/trace output

1: HTTP Error: connection lost

Anything else?

No response

Please confirm the following

schlimmchen commented 1 month ago

Please test this firmware.

gitisgreat2023 commented 1 month ago

Tested it, it works! Thanks alot, that was lightning fast!!

schlimmchen commented 1 month ago

You haven't noticed the PR I linked :wink: See #1183.

Thanks for testing. I will merge the PR, which will close this issue.

gitisgreat2023 commented 1 month ago

You haven't noticed the PR I linked 😉 See #1183.

Thanks for testing. I will merge the PR, which will close this issue.

I quickly scanned the commits here , didn't see any so thought better report a bug... Missed the PR link indeed, yeah looked at it, that was a little work it seems. Great you fixed it, thanks!

schlimmchen commented 1 month ago

Hm, let me clarify to make sure you know that I wasn't complaining: I mentioned again that I linked the respective PR because you said the fix was lightning fast. The fix took several hours, but I had completed it already.

I was not mentioning it because I thought you should have noticed before you opened this issue. On the contrary: I was waiting for someone (else) to report this :wink:

gitisgreat2023 commented 1 month ago

Okay got it... even with having it implemented already you were pretty fast in replying to my issue and referring to the right firmware... ;-)

github-actions[bot] commented 20 hours ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.