fix: Dynamic Power Limiter MQTT topics not carrying the hostname

helgeerbe / OpenDTU-OnBattery

Software for ESP32 to talk to Hoymiles Inverters and Victrons MPPT battery chargers (Ve.Direct)

GNU General Public License v2.0

253 stars 56 forks source link

fix: Dynamic Power Limiter MQTT topics not carrying the hostname #973

Open AndreasBoehm opened 1 month ago

AndreasBoehm commented 1 month ago

This fixes https://github.com/helgeerbe/OpenDTU-OnBattery/issues/963 by including the unique id of a DTU in the topics.

NOTE: This is a breaking change for existing users, as the topics will change.

The changes are based on https://github.com/helgeerbe/OpenDTU-OnBattery/blob/f0df583c13394b0f5e59e363e5ac77788a2663eb/src/MqttHandleHass.cpp#L331

schlimmchen commented 1 month ago

As far as I can tell, the "breaking" part of this PR is not too big of a deal. The respective topics are the same, only the entities for HomeAssistant auto discovery change. Does this mean workflows or automation for DPL values break?

AndreasBoehm commented 3 weeks ago

I need to re-test this as my home assistant installation is not working properly right now. I will let you know.

AndreasBoehm commented 3 weeks ago

This is how it looks in mqtt explorer now. Screenshot 2024-06-03 at 09 07 00