Closed eu-gh closed 4 months ago
@MalteSchm I guess this can be merged. However, I would be more confident if you'd agree.
So your change essentially says: If the user configured a SoC target of 100 there is no point in stopping and we disable this functionality.
Maybe I'm tired but it took me a longer time to figure this out. Could I ask you to clarify this in a comment?
// Done.
However, your comment made me realize that switching off the SoC limit toggle in the settings already does exactly the same thing. So I guess it would make more sense to simply don't accept values above 99 inside the UI, which is cleaner and also eliminates the problem I was trying to solve here.
FYI, I also added a clarification to the comment in line 432, since for people only using the Huawei charger (like me), it looks kind of redundant to add and subtract a current delta of almost zero over and over again.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.
Someone™ introduced the feature to set a maximum SoC limit for the combination Pylontech battery <-> Huawei AC charger. I've seen cases of a reported SoC of 100, but the BMS still requesting further charging, probably in order to do a proper cell calibration/soaking phase.
I added the simple exclude for an SoC Threshold < 100. Instead, the cutoff will be triggered by the BMS itself using the awesome new getChargeCurrentLimitation() method.