helgoboss / helgobox

Helgobox: ReaLearn & Playtime
https://www.helgoboss.org/projects/helgobox
GNU General Public License v3.0
204 stars 20 forks source link

ReaLearn error when deleting any track #857

Closed chords-chords closed 1 year ago

chords-chords commented 1 year ago

I get a ReaLearn error whenever I have a specific ReaLearn template in my project and I delete any track. I am pretty sure it's related to the "Track: Select/unselect" and/or "Track: Solo/unsolo" targets because this error didn't show up until I added these targets to my template.

I encounter this error with the previous stable version (2.14.3) and with the newest one as well (2.15.0).

Here's the error with v2.14.3:

--- cut ---

REAPER version: 6.77/x64 Module name: ReaLearn Module version: v2.14.3/x86_64 rev 68c524 (2023-01-13 17:18:04 UTC) Module base address: 0x7ff871780000 Module size: 0x1b63000

Message: Track not available

0: 0x7ff87288f135 - cpp_to_rust_ProjectStateContext_SetTempFlag 1: 0x7ff87288d989 - cpp_to_rust_ProjectStateContext_SetTempFlag 2: 0x7ff87279b7ff - DllMain 3: 0x7ff8728b3032 - cpp_to_rust_ProjectStateContext_SetTempFlag 4: 0x7ff8728b2d7a - cpp_to_rust_ProjectStateContext_SetTempFlag 5: 0x7ff8728b082f - cpp_to_rust_ProjectStateContext_SetTempFlag 6: 0x7ff8728b2a80 - cpp_to_rust_ProjectStateContext_SetTempFlag 7: 0x7ff872adb825 - cpp_to_rust_ProjectStateContext_SetTempFlag 8: 0x7ff872775ad6 - DllMain 9: 0x7ff871f2e766 - VSTPluginMain 10: 0x7ff8722c2a53 - VSTPluginMain 11: 0x7ff87205b102 - VSTPluginMain 12: 0x7ff872347cf1 - DllMain 13: 0x7ff871c453e6 - VSTPluginMain 14: 0x7ff8727cddaf - cpp_to_rust_IReaperControlSurface_Run 15: 0x14030d95c - 16: 0x1401fcf1f - 17: 0x1401fbe3c - 18: 0x14046e170 - 19: 0x7ff8ce9b2920 - ScreenToClient 20: 0x7ff8ce9b20c2 - ScreenToClient 21: 0x7ff8ce9fa359 - UnpackDDElParam 22: 0x7ff8ce9ae858 - CallWindowProcW 23: 0x7ff8ce9ae299 - DispatchMessageW 24: 0x14046765d - 25: 0x1409d5fa1 - 26: 0x7ff8ce847614 - BaseThreadInitThunk 27: 0x7ff8d05826a1 - RtlUserThreadStart --- cut ---

And here's the error with v2.15.0:

--- cut --- REAPER version: 6.80/x64 Module name: ReaLearn Module version: v2.15.0/x86_64 rev 7ba623 (2023-05-31 21:51:52 UTC) Module base address: 0x7ffab96e0000 Module size: 0x1e17000

Message: Track not available

0: 0x7ffaba99f6a5 - cpp_to_rust_ProjectStateContext_SetTempFlag 1: 0x7ffaba99eb52 - cpp_to_rust_ProjectStateContext_SetTempFlag 2: 0x7ffaba8ac608 - DllMain 3: 0x7ffaba9c287f - cpp_to_rust_ProjectStateContext_SetTempFlag 4: 0x7ffaba9c259b - cpp_to_rust_ProjectStateContext_SetTempFlag 5: 0x7ffaba9c014f - cpp_to_rust_ProjectStateContext_SetTempFlag 6: 0x7ffaba9c2290 - cpp_to_rust_ProjectStateContext_SetTempFlag 7: 0x7ffababf69b5 - cpp_to_rust_ProjectStateContext_SetTempFlag 8: 0x7ffaba89edc9 - DllMain 9: 0x7ffab9fd575f - VSTPluginMain 10: 0x7ffab9a707c3 - VSTPluginMain 11: 0x7ffab9769939 - NSEEL_HOSTSTUB_LeaveMutex 12: 0x7ffab9b0ad13 - VSTPluginMain 13: 0x7ffab9bde453 - VSTPluginMain 14: 0x7ffab9be2079 - VSTPluginMain 15: 0x7ffaba8df29f - cpp_to_rust_IReaperControlSurface_Run 16: 0x140307798 - 17: 0x1401fcf45 - 18: 0x1401fc4a8 - 19: 0x14046c744 - 20: 0x7ffb19782920 - ScreenToClient 21: 0x7ffb197820c2 - ScreenToClient 22: 0x7ffb197ca359 - UnpackDDElParam 23: 0x7ffb1977e858 - CallWindowProcW 24: 0x7ffb1977e299 - DispatchMessageW 25: 0x140463889 - 26: 0x1409dbac1 - 27: 0x7ffb18d97614 - BaseThreadInitThunk 28: 0x7ffb1a8026a1 - RtlUserThreadStart --- cut ---

I get this error on any kind of project (even on blank ones to which I add this ReaLearn template) whenever I do what I described above. I already sent the Reaper.ini file over e-mail 6 days ago.

Please let me know if you need anything else from me to replicate and fix this issue.

helgoboss commented 1 year ago

Try the latest release. If this doesn't work, please send me a minimal test RPP.

chords-chords commented 1 year ago

I'm not sure I understand. I wrote above that the error persists with the latest release (v2.15.0) too and I see no new pre-release when I synchronize ReaPack repositories. So is there a new release and it's only taking a bit longer to appear in ReaPack or did you mean v 2.15.0?

helgoboss commented 1 year ago

Ah you already tested with 2.15.0. Then I need the project file (more important than the REAPER INI file).

chords-chords commented 1 year ago

Here's both the project file and a "new" INI file. ReaLearn.zip REAPER.zip

helgoboss commented 1 year ago

Thanks, I could reproduce it. Fixing.

helgoboss commented 1 year ago

Hint: The following mapping is the culprit. It's definitely a bug in ReaLearn that an error message pops up, but besides this, you probably want to use target "Track" instead of "Track: Select/unselected". Otherwise it's like saying "I want text feedback about whether the currently selected track is selected or not" (which of course is always selected). And I should add, the "Track" target causes the same error, so it's not meant as a workaround.

image
chords-chords commented 1 year ago

Thank you! I'll keep your observation in mind and change the target when you update ReaLearn.