search

helium / rosetta-helium

Rosetta implementation for helium
18 stars 4 forks source link

Add sync error #33

Closed syuan100 closed 3 years ago

syuan100 commented 3 years ago

Add error for when node is still behind proper snapshot height (+50 above last blessed block)

abhay commented 3 years ago

This is good. Should we also add an error that tells you that the block age is greater than some number? Maybe something like if block age > 1 hour, you should probably wait before you do wallet operations?

syuan100 commented 3 years ago

Fortunately Rosetta actually automatically handles this with the sync para on the /network/status endpoint. Right now the threshold is 100 blocks. Would 50 make more sense? This will be a different PR though so I'm going to merge this one.

abhay commented 3 years ago

Fortunately Rosetta actually automatically handles this with the sync para on the /network/status endpoint. Right now the threshold is 100 blocks. Would 50 make more sense? This will be a different PR though so I'm going to merge this one.

No it's fine. Leave it as we have it :)