search

hello-robot / stretch_install

Install scripts for the Stretch mobile manipulators from Hello Robot Inc.
Other
7 stars 14 forks source link

Update dex wrist install script for ROS 2 #36

Closed hello-chintan closed 1 year ago

hello-chintan commented 1 year ago

Updates the stretch_new_dex_wrist_install.sh script to work with both ROS and ROS 2 depending on which distro is sourced.

hello-binit commented 1 year ago

Shouldn't it update both ROS and ROS2 workspaces, so users can switch between distros whenever they want and not have to run this script again?

hello-chintan commented 1 year ago

@hello-binit that would not work with how the configure_wrist.py script and the helper scripts in stretch_calibration like update_urdf_after_xacro_change.py are written currently. They use the subprocess library to make calls to 'ros2 run' which only works if ROS 2 is sourced. It's a bit of a pickle, I agree.

hello-chintan commented 1 year ago

@hello-binit what do you think, should I go ahead and merge this in?