search

heroku / heroku-connect-plugin

CLI plugin for Heroku Connect (experimental)
Apache License 2.0
23 stars 8 forks source link

Replace some our Q.Promise usage with co() #25

Closed gulopine closed 8 years ago

gulopine commented 8 years ago

I admit, I'm not entirely sure how generators, promises, Q.Promise and co() all fit together, so I'm probably missing something important here. Or perhaps doing something extra that I don't need. I've verified that the code does what it should, returns the right values, and raises exceptions in the right places. But I don't know if this is "right" in any real sense. This PR is hopefully a start toward simplifying things a bit, but mostly it's a way for me to try to learn how all this stuff works.

You'll likely need to add ?w=1 to the PR URL to reduce the noise from whitespace. It should make the changes a bit easier to spot.

gulopine commented 8 years ago

I appreciate any time you have on this, and I'm more than happy to do a hangout to discuss further, in hopes of understanding all of this a bit better.

hburrows commented 8 years ago

I think this all looks good.