search

heroku / heroku-connect-plugin

CLI plugin for Heroku Connect (experimental)
Apache License 2.0
23 stars 8 forks source link

Replace Toolbelt with CLI #76

Closed alouie-sfdc closed 7 years ago

alouie-sfdc commented 7 years ago

The old name is Toolbelt and the new name is CLI, according to https://devcenter.heroku.com/articles/heroku-cli

gulopine commented 7 years ago

Simple enough, but we also have https://github.com/heroku/heroku-connect-plugin/blob/master/lib/connect/api.js#L18. Do we want to do anything about that this point? It's mostly an internal thing, so it's not really a problem to leave it as toolbelt, but would it help to be consistent? The biggest downside to changing it would be that we'd have two values to keep track of for a while, until the old one fades far enough back for us to forget about it.

alouie-sfdc commented 7 years ago

I was wondering about that too -- I didn't change it because I wasn't sure if it was being used by any other system. Assuming that we're not doing anything with it at the moment, I'll go ahead and change it to cli.

sigmavirus24 commented 7 years ago

👍 :shipit:

alouie-sfdc commented 7 years ago

Thanks, @sigmavirus24. I've added another commit to bump the version.

sigmavirus24 commented 7 years ago

👍 :shipit: