search

heroku / heroku-connect-plugin

CLI plugin for Heroku Connect (experimental)
Apache License 2.0
23 stars 8 forks source link

specify files to pack to avoid oclif warning #94

Closed jdx closed 6 years ago

jdx commented 6 years ago

this attribute is now required in plugins otherwise a warning is displayed (though notably, the plugins still work fine with the warning)

See my blog post for the reason why this is now required: https://medium.com/@jdxcode/for-the-love-of-god-dont-use-npmignore-f93c08909d8d

for other plugins, if you run npm pack; tar -xvzf *.tgz; rm -rf package *.tgz that will print the files it's currently packing

sigmavirus24 commented 6 years ago

@jdxcode it seems the netrc parser is not working on the version of node we're using? This clearly has nothing to do with your change, but it's not something I'm familiar with. I don't think this is a direct dependency of ours. Do we need to update something else to fix this?

jdx commented 6 years ago

you likely need to update the node version in the circle config

sigmavirus24 commented 6 years ago

Any suggestions on the right version to be using?

jdx commented 6 years ago

use 10.2.1 (the latest) that's what the CLI is on now

jdx commented 6 years ago

FYI @sigmavirus24 this plugin is using Circle 1.0 which I think is going away in August. I'll work up a PR to move it to Circle 2.0 for you as it's not super straightforward

jdx commented 6 years ago

https://github.com/heroku/heroku-connect-plugin/pull/95

sigmavirus24 commented 6 years ago

I'm going to close this and re-open it to trigger a new merged build

jdx commented 6 years ago

went ahead and rebased it

sigmavirus24 commented 6 years ago

👍