herumi / mcl

a portable and fast pairing-based cryptography library
BSD 3-Clause "New" or "Revised" License
450 stars 152 forks source link

Added $BIT to ASM related build calls in Makefile #154

Closed mxaddict closed 1 year ago

mxaddict commented 1 year ago

Related to this comment: https://github.com/herumi/mcl/issues/153#issuecomment-1234514336

mxaddict commented 1 year ago

as --64 seems to fail on OSX, will see if I can figure out how to get that to work

mxaddict commented 1 year ago

@herumi I tested this PR and seems to be working well.

I think it's ready for review

mxaddict commented 1 year ago

If we set up $(CLANG_TARGET) properly, I would think m$(BIT) would be unnecessary. What do you think?

I think you are right.