herumi / mcl

a portable and fast pairing-based cryptography library
BSD 3-Clause "New" or "Revised" License
450 stars 151 forks source link

Make MCL_STATIC_LIB completely static #204

Closed jagerman closed 1 month ago

jagerman commented 1 month ago

Currently the MCL_STATIC_LIB option will produce static mcl::mclbn{N} targets, but these static targets still link to the non-static mcl::mcl and so you end up with a half-static result that still depends on a dynamic lib.

This fixes it to link to the mcl::mcl_st static target when MCL_STATIC_LIB is enabled (and mcl::mcl otherwise).

herumi commented 1 month ago

Thank you for your contribution. I'll merge it with the main branch later.

herumi commented 1 month ago

https://github.com/herumi/mcl/commit/01d1a430780bb7c3b6b2f00a919d90181e17b7f8