Add shared library version and other packaging changes

herumi / mcl

a portable and fast pairing-based cryptography library

BSD 3-Clause "New" or "Revised" License

452 stars 152 forks source link

Add shared library version and other packaging changes #21

Closed infinity0 closed 5 years ago

infinity0 commented 6 years ago

install to libmcl.so rather than libmcl_dy.so as most distributions expect this
gitignore Makefile since it's generated by cmake
fix being able to override DOWNLOAD_SOURCE, it was always being set to ON before

Of course the version number 1.0.0 is only a suggestion, you can choose whatever you think is best - keeping in mind the semantics of how most systems expect it to go that I documented in the comments.

herumi commented 5 years ago

I modify mcl to contain xbyak and cybozulib, so mcl can be built without them.

infinity0 commented 5 years ago

It is still beneficial to commit to a stable API and provide a shared library version scheme that trackes ABI compatibility, but that's less urgent for dfinity and I'll file a separate issue for that.