Closed alexandervdm closed 4 years ago
Thank you for the patch.
About https://github.com/herumi/mcl/pull/83/commits/16874a19f650c6c6a7a7a39a456a69e4cbe30512 , I think that -DNDEBUG
should be defined on a release mode and clang supports the other options.
You are correct, thanks for accepting b575c9c18821704e1fa84f7517bff3cd578340ba
This PR allows mcl to be built on OpenBSD using the Makefile. Modern releases of OpenBSD include both clang and gcc in the base system. Building mcl on the included version of gcc however is problematic since it is ancient (v4.2.1) and results in a cascade of missing instruction (mulxq) errors. The changes in this PR configure the Makefile to use the clang compiler instead on OpenBSD.
Build log: https://pastebin.com/raw/48zfguVL
Also included is a patch that moves some build flags that are specific to gcc to an underlying conditional block to prevent them from being used for clang.
Test results on my OpenBSD-current system:
If you are interested in this PR, I'd be happy to improve upon it - such as adding support to the CMake build system.