search

herumi / mcl

a portable and fast pairing-based cryptography library
BSD 3-Clause "New" or "Revised" License
458 stars 157 forks source link

DST in msgToG1 #85

Closed lgremy closed 3 years ago

lgremy commented 4 years ago

Hi, in the function void msgToG1(G1& out, const void *msg, size_t msgSize) const of include/mcl/mapto_wb19.hpp, I suppose that the DST should be BLS_SIG_BLS12381G1_XMD:SHA-256_SSWU_RO_POP_ instead of BLS_SIG_BLS12381G2_XMD:SHA-256_SSWU_RO_POP_.

I may do a PR to solve this issue if I did not do a mistake.

herumi commented 3 years ago

Thank you for the useful feedback. Is it okay ? https://github.com/herumi/mcl/commit/0d9af2d2032960919fc6e656262e3a318922b249

lgremy commented 3 years ago

Yes, thanks!