Use Granite.validatedentry for password setup/entry

[hanaral]

The current widget looks a little too tall (that's not that much of an issue) but more importantly it doesnlt use a symbolic icon for the tick, which shouldn't be a button if it's inside the box itself (the only exception I can think of is the refresh button in Files etc.) I think copying the login greeter's arrow button could go nicely!

[hanaral]

Also use a tickbox for the password revealer, it's waaay more accessible!

[hezral]

thanks for this. i'll look into it

[hezral]

got the basics done, need to refactor the methods

[hezral]

@hanaral you can try the latest version now. password ui completely revamped, also added a toggle for protected mode. Just move existing ~/.var/app/com.github.hezral.clips to somewhere first to test it fresh.

[hanaral]

The new look is much improved, nice work! A couple of regressions I found were these:

• There is now an authenticate button in the 'old password' entry when changing the password, even though the apply button is at the bottom
• Clicking the 'set password' button when setting up a fresh install didn't do anything, but clicking 'skip protection' for some reason set it as if it worked

Three non-critical nitpicks are:

• The bottom two buttons aren't using the normal elementary padding, but I get why you wanted it to be inline with the other widgets
• The password setup dialogue has a close button (in the top left) even though it's a dialogue with a cancel button at the bottom
• The button order is inverted to the elementary default:

[hezral]

There is now an authenticate button in the 'old password' entry when changing the password, even though the apply button is at the bottom It's the same for how the account change password works in the elementary Accounts switchboard. I've changed the behaviour depending on the context of when the password dialog is invoked.

Clicking the 'set password' button when setting up a fresh install didn't do anything, but clicking 'skip protection' for some reason set it as if it worked Thanks, fixed it now

The bottom two buttons aren't using the normal elementary padding, but I get why you wanted it to be inline with the other widgets yeah, i changed it a bit now

The password setup dialogue has a close button (in the top left) even though it's a dialogue with a cancel button at the bottom Initially i didn't put an ESC to dismiss and forgot to remove it after i did :) gone now

The button order is inverted to the elementary default Was bugging me too, forgot to recheck

[hanaral]

Nice work!