search

hezral / clips

Multi format clipboard manager with extra features
GNU General Public License v3.0
39 stars 1 forks source link

Fails to launch #8

Closed danirabbit closed 3 years ago

danirabbit commented 3 years ago

After installing Clips using the bundle here, it fails to launch with this Terminal output:

flatpak run com.github.hezral.clips 
Traceback (most recent call last):
  File "/app/bin/com.github.hezral.clips", line 40, in <module>
    from clips import main
  File "/app/share/com.github.hezral.clips/clips/main.py", line 27, in <module>
    from .custom_shortcut_settings import CustomShortcutSettings
ModuleNotFoundError: No module named 'clips.custom_shortcut_settings'
hezral commented 3 years ago

Removed the code to use CustomShortcutSettings as it no longer works in flatpaks. Build successfull https://github.com/hezral/clips/actions/runs/1160602024

Do i need to submit a new release?

cassidyjames commented 3 years ago

@hezral yes, you'll need to create a new release so we can submit that to AppCenter.

hezral commented 3 years ago

Thanks @cassidyjames

hezral commented 3 years ago

Just to confirm, create a new release, go to AppCenter dashboard to submit again.

https://github.com/elementary/appcenter-reviews/pull/91 will still be used for the submission process or a new PR will need to be created?

danirabbit commented 3 years ago

@hezral I've updated the PR on the reviews repo with the new commit hash

In the future, please try to avoid rewriting history. It makes it harder to review since we have to start over from scratch instead of being able to compare the difference between release tags

hezral commented 3 years ago

thanks, i was experimeting 😄

hezral commented 3 years ago

Fixed with https://github.com/hezral/clips/releases/tag/1.0.1