search

hiclib / pastis

Poisson-based algorithm for stable inference of DNA Structure
http://hiclib.github.io/pastis/
Other
34 stars 15 forks source link

Output 3D co-ordinates in PDB format as was done by coords.cpp #19

Closed gbonora closed 7 years ago

NelleV commented 7 years ago

That looks good! Can you run a static check tool like flake8 to identify the formatting issues on the file? It should pick up on everything that doesn't follow the contributions guideline.

If you use vim or emacs, flake8 can be integrated in the editors to run automatically. SublimeText also has it by default.

Thanks for the patch, N

gbonora commented 7 years ago

OK. I've incorporated the recommendations that you made in the 3rd commit.

Re. flake8, I'm using PyCharm, which has code analysis built in. Is this sufficient?

Giancarlo

NelleV commented 7 years ago

Yes, Pycharm does pep8 and pyflakes out of the box. Thanks for the patch!