hiddenSymmetries / simsopt

Simons Stellarator Optimizer Code
https://simsopt.readthedocs.io
MIT License
83 stars 43 forks source link

Clean up dofs of Vmec objects #388

Closed landreman closed 6 months ago

landreman commented 6 months ago

With this PR, pres_scale is added as an optimizable d.o.f. of Vmec objects, allowing the pressure profile to be scaled up and down.

Previously, Vmec objects also had some optimizable dofs that really should not ever be varied in an optimization: delt, tcon0, and gamma. These parameters are now removed as optimizable dofs.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (01aac45) 91.44% compared to head (0c0c5f0) 91.44%. Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #388 +/- ## ========================================== - Coverage 91.44% 91.44% -0.01% ========================================== Files 73 73 Lines 12717 12715 -2 ========================================== - Hits 11629 11627 -2 Misses 1088 1088 ``` | [Flag](https://app.codecov.io/gh/hiddenSymmetries/simsopt/pull/388/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hiddenSymmetries) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/hiddenSymmetries/simsopt/pull/388/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hiddenSymmetries) | `91.44% <100.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hiddenSymmetries#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.