search

hiddenSymmetries / simsopt

Simons Stellarator Optimizer Code
https://simsopt.readthedocs.io
MIT License
83 stars 43 forks source link

Enhancements to analytic fields in magneticfieldclasses.py #391

Open smoniewski opened 5 months ago

smoniewski commented 5 months ago

While adding dofs to CircularCoil in #377, a couple points were raised. I thought they were out of the scope of the pull request, so I am repeating them here.

  1. https://github.com/hiddenSymmetries/simsopt/pull/377#issuecomment-1799034721 > what about the other magnetic fields in this file (ToroidalField, PoloidalField, DipoleField, etc)? they don't have this added support. Not saying that we need to, but just something that I noticed.
  2. https://github.com/hiddenSymmetries/simsopt/pull/377#issuecomment-1814173449 > this field is tied to a specific coil, but that coil is not a geometry object. So this coil will not work for any of the regular curve objectives. Perhaps we should have a CircularCoil curve object that gets its field from CircularCoilField.