search

hiddenSymmetries / simsopt

Simons Stellarator Optimizer Code
https://simsopt.readthedocs.io
MIT License
83 stars 43 forks source link

Version bump for various Actions used in Workflows #392

Closed mbkumar closed 5 months ago

mbkumar commented 5 months ago

The recommended versions for many Actions used in the workflows have been changed. This PR brings the Actions versions to the latest ones.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (83c2cb4) 91.08% compared to head (193b89e) 91.44%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #392 +/- ## ========================================== + Coverage 91.08% 91.44% +0.36% ========================================== Files 73 73 Lines 12715 12715 ========================================== + Hits 11581 11627 +46 + Misses 1134 1088 -46 ``` | [Flag](https://app.codecov.io/gh/hiddenSymmetries/simsopt/pull/392/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hiddenSymmetries) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/hiddenSymmetries/simsopt/pull/392/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hiddenSymmetries) | `91.44% <ø> (+0.36%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hiddenSymmetries#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

landreman commented 5 months ago

Hmm, in the last commit to the infra branch just now, I tried updating more of the github-actions package versions. Now github actions is giving errors "Conflict: an artifact with this name already exists on the workflow run." Does this mean there is a problem with some of the newer versions of the actions? Should we revert some of those changes I just made, or do something else to fix the error?

mbkumar commented 5 months ago

There is a warning for upload-artifact and download-artifact actions.

Important

upload-artifact@v4+ is not currently supported on GHES yet. If you are on GHES, you must use [v3](https://github.com/actions/upload-artifact/releases/tag/v3).

Let me bump down the versions for these two.