hiddenSymmetries / simsopt

Simons Stellarator Optimizer Code
https://simsopt.readthedocs.io
MIT License
94 stars 45 forks source link

Tweak for compatibility with jax 0.4.25 #397

Closed landreman closed 7 months ago

landreman commented 7 months ago

In jax 0.4.25, released last month, jax.config.config was deprecated, which causes simsopt to break with this jax version. In particular the CI is failing. This PR is a fix. The change works with older jax versions too - simsopt was already using the new syntax import jax; jax.config.update(...) in another location (geo/jit.py.)

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.44%. Comparing base (faa129a) to head (7787fcc).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #397 +/- ## ======================================= Coverage 91.44% 91.44% ======================================= Files 73 73 Lines 12715 12715 ======================================= Hits 11627 11627 Misses 1088 1088 ``` | [Flag](https://app.codecov.io/gh/hiddenSymmetries/simsopt/pull/397/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hiddenSymmetries) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/hiddenSymmetries/simsopt/pull/397/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hiddenSymmetries) | `91.44% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hiddenSymmetries#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.