codecov[bot]
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.56%. Comparing base (
7d88bd9) to head (b0bb926). Report is 3 commits behind head on master.:exclamation: Current head b0bb926 differs from pull request most recent head bc79d97. Consider uploading reports for the commit bc79d97 to get more accurate results
Additional details and impacted files
```diff @@ Coverage Diff @@ ## master #410 +/- ## ========================================== + Coverage 91.10% 91.56% +0.46% ========================================== Files 74 74 Lines 12956 12923 -33 ========================================== + Hits 11803 11833 +30 + Misses 1153 1090 -63 ``` | [Flag](https://app.codecov.io/gh/hiddenSymmetries/simsopt/pull/410/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hiddenSymmetries) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/hiddenSymmetries/simsopt/pull/410/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hiddenSymmetries) | `91.56% <100.00%> (+0.46%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hiddenSymmetries#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR adds a convenience function to make
SurfaceRZFouriersurfaces that are rotating ellipses.I decided not to make this a
@classmethodso users have the option to specify eitherquadpoints_thetaandquadpoints_phi, or specifyrange,nphi, andnthetawith@classmethod from_nphi_ntheta().