hiddenSymmetries / simsopt

Simons Stellarator Optimizer Code
https://simsopt.readthedocs.io
MIT License
94 stars 45 forks source link

ag/cross section fix #428

Open andrewgiuliani opened 3 months ago

andrewgiuliani commented 3 months ago

I have used the Surface.cross_section algorithm on the entire QUASR database, and notice that very infrequently, the algorithm fails, see below

image

I rewrote the algorithm, making it simpler, to fix the bug. Rerunning the new algorithm on the entire dataset, I can't find any incorrect cross sections anymore.

image

Note that the jagged cross section where varphi=0 is because it uniformly samples the cross section in the Boozer theta angle, which may be insufficient as you can see.