hilbert / hilbert-cli

Backend management tools: CLI
Apache License 2.0
6 stars 2 forks source link

Feature/hilbert server tool update packaging testing #75

Closed malex984 closed 6 years ago

malex984 commented 6 years ago
porst17 commented 6 years ago

So you are already partially removing Python 2.7 support here the testing and packaging part)? But removing the Python 2.7 bits is not complete, right? I would approve the PR if it would also remove the extra Python 2.7 code, if any. Needs to be discussed.

Actually, removing Python 2.7 support should be separate and not mixed with updating build scripts. packaging etc. But I can live with it coming as a bigger PR.

malex984 commented 6 years ago

No, it is more like preparation for deprecation of Python2 support: just to stop running unit-tests under Python2 (which is cheap and easy), while doing that for recent Python versions instead.

Complete removal of PY2 (in favor of PY3) support may be done later on.

porst17 commented 6 years ago

Dropping Python 2.x support will be tracked in #76 .

malex984 commented 6 years ago

@porst17 unfortunately i cannot restore the previous branch (before rebaseing it on HEAD) :-( the only real change was due to your last comment: reverted to 0.3.0 in setup.py.