hilbert / hilbert-docker-images

Application with a dynamic choice of docker containers to run
Apache License 2.0
22 stars 8 forks source link

Separate shared helper scripts into a separate sub-folder #37

Closed malex984 closed 6 years ago

malex984 commented 7 years ago

E.g. upgrade.sh/update.sh/install/clean.sh, setup_ogl, launcher.sh etc

malex984 commented 6 years ago

@porst17 No, those scripts belong to directories of corresponding images (e.g. hilbert/base, hilbert/gui) due to restrictions of docker build. IMO this can be closed.

porst17 commented 6 years ago

The Dockerfile now includes these scripts via COPY update.sh install.sh upgrade.sh clean.sh /usr/local/bin/, i.e. they will be reused in derived images. This satisfies sharing for me.