search

hire-a-senior / backend

0 stars 2 forks source link

Creating a Constant handler and tests to the corresponding services #123

Open Mert18 opened 1 year ago

Mert18 commented 1 year ago

There are frequently used strings in the different parts of the application (such as "You are not authorized" when returning ApiResponse) . Find and define a constant for them and call the constant class instead.

yekxp commented 1 year ago

Hello, my name is Jakub and I am a student of Technical University in Kosice and software developer in Siemens Healthineers and I would be very happy if I could work on this issue. It would be the part of the course where we have to help a project on GitHub. Could you assign me to it, please?

Mert18 commented 1 year ago

Welcome! If you have any questions about this issue please ask. Do not forget to open a pull request to "develop" branch when you are done :)

yekxp commented 1 year ago

Can I add tests for individual services that will use my constants? (If so, could you please change the title of the issue to "Creating a Constant handler and tests to the corresponding services"), Thank you for response. I have idea with mocking without disrupting the database and for smooth operation. Jake

Mert18 commented 1 year ago

Alright, I have updated the title.