crdoconnor
commented
1 year ago Hi Tim,
Thank you for trying it out!
The cleanest way right now would probably be to instantiate the engine class in the test method.
The down-side of this approach of course is that you would have to create a new method for each test and you wouldn't be able to use this method to seamlessly convert user stories into tests:
collection.with_external_test_runner().ordered_by_name().add_pytests_to(
module=__import__(__name__) # This module
)So, it would work fine if you have 3-5 tests but would get annoying if you had more.
I feel like the cleanest approach would, in your case, be to add a fixtures parameter to the "add_pytests_to" method. Would you like me to add this feature so you can do that?
E.g.
collection.with_external_test_runner().ordered_by_name().add_pytests_to(
module=__import__(__name__),
fixtures=[client],
)And in the step methods you could reference "self.fixtures.client".
If you're keen on this idea, I could potentially add this feature a bit later on today and push out a new release.
On Wed, Jun 7, 2023 at 1:45 PM Tim Martin @.***> wrote:
I'm testing some Django code, and I'd like to use the Django test client. This is available in Pytest via pytest-django providing a client fixture https://pytest-django.readthedocs.io/en/latest/helpers.html#client-django-test-client .
It's meant to be used like this:
def test_with_client(client): response = client.get('/') assert response.content == 'Foobar'
I think the most natural way to adapt this to the Hitchstory approach is to add the decorator to my test_foo Pytest function:
def test_foobar(client): hs.named("Something with a client").play()
but it's not obvious there's a clean way to pass the client object through so that the engine can get at it. I think the client is recreated with each test (it potentially holds state) so we don't want to create the client once and include it when instantiating the engine.
— Reply to this email directly, view it on GitHub https://github.com/hitchdev/hitchstory/issues/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOJKNLPY4MZVIPYORIBXLTXKBZV5ANCNFSM6AAAAAAY52DJBU . You are receiving this because you are subscribed to this thread.Message ID: @.***>
timmartin
I'm testing some Django code, and I'd like to use the Django test client. This is available in Pytest via
pytest-djangoproviding a client fixture.It's meant to be used like this:
I think the most natural way to adapt this to the Hitchstory approach is to add the decorator to my
test_fooPytest function:but it's not obvious there's a clean way to pass the client object through so that the engine can get at it. I think the client is recreated with each test (it potentially holds state) so we don't want to create the client once and include it when instantiating the engine.