hitontology / gui

Erneuerung der Benutzungsoberflächen von HITO
https://hitontology.github.io/gui/
MIT License
0 stars 0 forks source link

prevent concurrent path selection table calculations #38

Closed KonradHoeffner closed 7 months ago

KonradHoeffner commented 7 months ago

@Yagnap: the redundant path display code did not work anymore (maybe I broke it?) so I had to disable this:

  if (path !== getPath()) {
    notyf.error("New path was selected while SPARQL query was run. Not displaying old path results now.");
    return;
  }

I think this doesn't catch the case where a user repeatedly selects the same path that is already selected, possibly due to insufficient user feedback.

We should fix and improve this in the following way:

KonradHoeffner commented 7 months ago

This does not work for me even after CTRL+F5 and npm install.

KonradHoeffner commented 7 months ago

P.S.: Ah, it covers the case where the user selects the same source again, but not when just the target is selected again, I will fix this. It also doesn't prevent the repeated SPARQL query on path selection.

KonradHoeffner commented 7 months ago
KonradHoeffner commented 7 months ago

The current code also just notifies but doesn't actually stop the recalcuation :-)