search

hjdhjd / homebridge-doorbird

Homebridge plugin for Doorbird
Apache License 2.0
55 stars 14 forks source link

Manufacturer / Model / Serial characteristic support. #1

Closed hjdhjd closed 7 years ago

hjdhjd commented 7 years ago

Great plugin, works well.

I'd appreciate adding in proper support for Manufacturer / Model / Serial characteristics so those of us with multiple devices can better describe them to HomeKit. (e.g. D101 vs D202 Doorbird models).

brownad commented 7 years ago

I only did that to mark my motion sensor but there's no real discovery I will look at making it more generic for other units

hjdhjd commented 7 years ago

Just add in the ability to specify model / manufacturer / serial like most of the other plugins…seems like just a couple of lines of code, no?

On Apr 9, 2017, at 4:27 PM, brownad notifications@github.com wrote:

I only did that to mark my motion sensor but there's no real discovery I will look at making it more generic for other units

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/brownad/homebridge-doorbird/issues/1#issuecomment-292814277, or mute the thread https://github.com/notifications/unsubscribe-auth/ATOK-YaH9kc0OIxGJVFyb86GxR5zDmwqks5ruU1KgaJpZM4M4FVn.

brownad commented 7 years ago

Yeah that's possible I can move it to the config. This plugin is really just a stop gap to give some notifications to DoorBird ideally a plugin is made that brings together camera, sensors and a pseudo doorbell but that's a bit more to think about and needs audio to work to even be worth it - nothing I've seen yet

I'll make a change soon for the manufacturer and serial and default to the lowest option

Sent from my iPhone

On 9 Apr 2017, at 22:30, hjdhjd notifications@github.com wrote:

Just add in the ability to specify model / manufacturer / serial like most of the other plugins…seems like just a couple of lines of code, no?

On Apr 9, 2017, at 4:27 PM, brownad notifications@github.com wrote:

I only did that to mark my motion sensor but there's no real discovery I will look at making it more generic for other units

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/brownad/homebridge-doorbird/issues/1#issuecomment-292814277, or mute the thread https://github.com/notifications/unsubscribe-auth/ATOK-YaH9kc0OIxGJVFyb86GxR5zDmwqks5ruU1KgaJpZM4M4FVn.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

brownad commented 7 years ago

That's done now, defaults back to the D101 if not supplied