search

hluk / CopyQ

Clipboard manager with advanced features
GNU General Public License v3.0
8.35k stars 432 forks source link

CopyQ windows have the wrong `activationPolicy` #1330

Open lwouis opened 4 years ago

lwouis commented 4 years ago

Describe the bug

My app alt-tab-macos queries the OS for all the NSRunningApplications currently running. In that list, we check each app activationPolicy. CopyQ's policy is incorrectly set as .prohibited. Apple's docs describe this policy as:

The application doesn’t appear in the Dock and may not create windows or be activated.

Because apps having the .prohibited policy are not supposed to open windows, we ignore them in alt-tab-macos. However CopyQ does open windows, thus we had to whitelist it specifically:

https://github.com/lwouis/alt-tab-macos/blob/e40f859c3a60a3d64fafc8147d4c2a7d3f8e6a45/src/logic/Applications.swift#L68

Expected behavior

I think CopyQ should have the .accessory policy.

Version, OS and Environment

Additional context

I think this is where this is set in CopyQ:

https://github.com/hluk/CopyQ/blob/e2067d4f317857b49afd18bddd6d545480fb51a2/src/platform/mac/macplatform.mm#L158

I suggest you use .accessory instead. What do you think?

hluk commented 4 years ago

Unfortunately, many tests fail on macOS if I set "accessory" or "regular" activation policy. Not sure what's going on - I cannot test it on macOS currently.