hluk / CopyQ

Clipboard manager with advanced features
GNU General Public License v3.0
8.69k stars 441 forks source link

CopyQ 5.0.0.19 - Issues to solve #1773

Open bovirus opened 3 years ago

bovirus commented 3 years ago

Before creating a new issue, see list of known issues.

Describe the bug

Italian language file not updated.

image

This is a string not availble in Weblate repository Theer is no a simple string "Visualizza/nascondi)

Seems that the program didn't get latest translation from Weblate. Ex.

"Aggiungi tag" was modifeid as "Aggiungi etichetta" "Rimuovi tag" was modified "Rimuovi etichetta". But latest v4rsion of the program has again "Aggiunti tag" / "Rimuovi tag".

control wdth not enough

CopyQ 5 0 0 - GUI - 03

Please increase width space for "predefinito" string.

To Reproduce

Expected behavior

Screenshots

Version, OS and Environment

Additional context

hluk commented 3 years ago

Theer is no a simple string "Visualizza/nascondi)

Original string is "&Show/Hide" and translated version "Vi&sualizza/nascondi".

"Aggiungi tag" was modifeid as "Aggiungi etichetta" "Rimuovi tag" was modified "Rimuovi etichetta". But latest v4rsion of the program has again "Aggiunti tag" / "Rimuovi tag".

The problem is that there is already a command with old translated name in the Command dialog. If you delete the commands with old names, the commands with updated name should be added.

These internal menu/shortcut actions are added to the Command dialog so that user can change the name or behavior easily. But this is a bit broken because changing app language won't retranslate the command names automatically (and in turn the menu actions will have the old name also).

There are other problems/inconsistencies this can cause. One simple solution would be not to add the internal actions to commands. But I might need to figure out how to allow users to disable these actions in menu/toolbar.

control wdth not enough

Yup, this has been already reported. Not sure if there is an issue for this but I think it's only problem with the Windows style in Qt.

hluk commented 3 years ago

One simple solution would be not to add the internal actions to commands. But I might need to figure out how to allow users to disable these actions in menu/toolbar.

Actually, this is not so simple because the custom shortcuts from Preferences are stored in the commands. Additionally, there would be no way to set order of actions in menu/toolbar.

bovirus commented 3 years ago

@hluk

I identified that is not an CopyQ application problem but a Weblate export fufile function that seems not work as expected.

hluk commented 3 years ago

I fixed updating the command/action name translations in commit 6f307d71fc7ce8223af1b0c232cc5e298652cddf. Unfortunately, you will have to remove the commands previously automatically added in the Command dialog.

bovirus commented 3 years ago

@hluk

Which command? Could you make all changes that it needs?

hluk commented 3 years ago

If you open Command dialog you would usually see some commands that were added automatically by CopyQ. The problem is that names of those commands (and menu/toolbar actions in consequence) were not updated when the app language changed or a new app version was installed.

The fix is to add special attribute to these commands so CopyQ knows to keep them updated. Unfortunately, the commands already in the Command dialog does not have the attribute. I could not think of a safe way to update them (user may have already done some modifications) so they need to be deleted explicitly by user so CopyQ can add the new versions.