hmsiccbl / screensaver1

Screensaver Version 1 - End of life on December 1, 2018
GNU General Public License v2.0
3 stars 3 forks source link

Date first plated is incorrect for some libraries #161

Open seanderickson opened 9 years ago

seanderickson commented 9 years ago

@JAS60 writes: From the small molecule library page in Screensaver (with all libraries listed), I noticed the date first plated for MLP is in 2014, even though they were received and screened in 2011. @dwrobel1 : That's a mystery to me. I actually don't enter the date first plated information and can't think of anything I do that would change this value. Looking at MLP-1 as an example, the last load I did was in March 2012 but the date first plated is April 2014. If you look at the copy information it also has April 2014 as the date plated

Background: According to the code, the "Date First Plated" for the library is set in two cases:

(see https://github.com/hmsiccbl/screensaver/blob/00a09f55d302242a06721ce0af74e4597ff1b0ad/batch/src/main/java/edu/harvard/med/screensaver/io/libraries/LibraryCreator.java#L148 and https://github.com/hmsiccbl/screensaver/blob/dc9b76ab68558d270182d6269ebc4a67639e6ffd/core/src/main/java/edu/harvard/med/screensaver/service/libraries/PlateUpdater.java#L341)

Given these conditions, I am not sure why the date first plated was set to 2014; I can deduce, however, that this value may not have been set yet when, on 2014/04 the plates were created.