hollance / TheKissOfShame

DSP Magnetic Tape Emulation
https://audiodev.blog/kiss-of-shame/
GNU General Public License v3.0
101 stars 4 forks source link

Bug: the Tape Type resets after plugin close #11

Open Olaf-Tryggvasson opened 2 months ago

Olaf-Tryggvasson commented 2 months ago

Hi, I love the sound of your plugin, I like the options, and the auto-gain feature.

I've found a bug that persists in version 1.0.1 - namely, every time you close the plugin, on open the tape type reverts to 5-M.

Other issues:

The plugin increases the output level, just by passing signal through it, regardless of the Input trim setting,

Request: please remove the inverted cross - maybe any religious reference altogether. It makes me sick every time I open it, because I know what it stands for. There's no need for that in audio processing, and I really like your plugin and I'd like to use it. So far, I haven't put it in any project, even though I love the sound, because of this issue, and the tape type revert. If these two things are solved, I'd be happy to use it. Otherwise, great work.

Thanks!

hollance commented 2 months ago

Hi Olaf, thanks for the feedback!

I've found a bug that persists in version 1.0.1 - namely, every time you close the plugin, on open the tape type reverts to 5-M.

The tape type setting is not implemented at all, so it's not really a problem that the switch resets when you reopen the plug-in. Of course, once the tape type setting will be properly implemented, this should be fixed. However, the goal of this project was to bring this old plug-in back to life and no source code was provided for the tape type emulation, so I doubt it will ever get added.

The plugin increases the output level, just by passing signal through it, regardless of the Input trim setting,

Correct. It always applies some amount of saturation, even with Input Trim all the way down.

Request: please remove the inverted cross - maybe any religious reference altogether. It makes me sick every time I open it, because I know what it stands for.

Like I said, the point of this project was to get an old plug-in to work again on modern machines. The inverted cross is part of the original plug-in's design. I can understand that you dislike it but I have no plans to change it. Since this is open source, someone could fork this project and replace those images and make their own version of this plug-in. But that is not something I am willing to do.