holomorph
commented
8 years ago Thanks for the patch.
For the bindings, I'd consider binding it to m for the sake of staying to familiar to dired, buffer menu, ibuffer, etc., though u for unmark is still taken... Alternatively, t for "tag" (changing transmission-trackers-add to k perhaps). The new command is a toggle anyways, so perhaps it's better to use a name distinct from that in dired and friends, since its behavior is not quite the same (separate commands for mark/unmark).
For faces, it's no longer needed to make a variable, as named faces are symbols. In any case, I have no plans to add custom faces.
My main reservation is that I don't think it makes sense to add this only for the torrent list. Marks/tags should also be usable in the file listing. This complicates things, but I think this is a useful feature, so I'm inclined to pull this into a branch.
This change features two new commands:
transmission-toggle-mark— mark/unmark torrent at point. It's bound to x; I would be happy to use SPC instead, but it's already bound toscroll-upby the parent mode.transmission-unmark-all— remove all marks (bound to U).Marking takes precedence over selecting torrents via regions in functions which use
transmission-let*-ids. That is, if there're marked torrents, their IDs are bound toidsintransmission-let*-ids(with fallback to the IDs obtained viatransmission-prop-values-in-regionif none torrents are marked).Closes #3.