search

home-assistant / android

:iphone: Home Assistant Companion for Android
https://companion.home-assistant.io/
Apache License 2.0
2.35k stars 656 forks source link

Missing genitiv apostrophe in some UI strings #4704

Closed NoRi2909 closed 1 month ago

NoRi2909 commented 1 month ago

Home Assistant Android app version:

2024.9.4-full

There are three UI strings (found via Lokalize) that are missing an apostrophe to indicate the genitive and form a wrong plural instead:

 sensor_description_app_standby
 "The apps current standby bucket.  …"

This should be "The app's …" as seems to refer to the Companion app itself.

 sensor_description_geocoded_location
 "… Googles Location API. …"

 sensor_description_detected_activity
 "… Googles Activity Recognition API"

Both contain "Googles" which should be "Google's" instead.

dshokouhi commented 1 month ago

Hello all our english strings are managed in this file and not in Lokalize

https://github.com/home-assistant/android/blob/master/common/src/main/res/values/strings.xml

If you like you should be able to create some edits and submit as a PR so we can get these corrected.

NoRi2909 commented 1 month ago

@dshokouhi I'm quite fluent in Lokalize, but that would be my first edit on Github. So perhaps you can fix this in this case? :-)

NoRi2909 commented 1 month ago

Here is an additional bug with the wrong plural vs. genitive:

 sensor_description_audio_sensor
 The state of the devices ringer mode

Should be "device's" here.