home-assistant / android

:iphone: Home Assistant Companion for Android
https://companion.home-assistant.io/
Apache License 2.0
2.34k stars 656 forks source link

Correct sensor identification for car speed sensor #4746

Closed dshokouhi closed 1 month ago

dshokouhi commented 1 month ago

Summary

This should be a sensor and not diagnostic

Screenshots

Link to pull request in Documentation repository

Documentation: home-assistant/companion.home-assistant#

Any other notes

jpelgrom commented 1 month ago

What is your reasoning here? As I understand it we should use diagnostic for sensors that you cannot directly influence. I can understand car speed as primary but range remaining feels like it should be classified diagnostic similar to the battery remaining charge time sensor.

dshokouhi commented 1 month ago

What is your reasoning here? As I understand it we should use diagnostic for sensors that you cannot directly influence. I can understand car speed as primary but range remaining feels like it should be classified diagnostic similar to the battery remaining charge time sensor.

Agreed reverted the change for car range remaining. Received a comment from an internal tester about their identification but I probably shouldve given it a lil more thought :)